build: no longer require updating multiple package.json files for bazel #14391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/no-longer-require-updating-multiple-package-json-bazel
branch
from
bf0514e to
b056693
Compare
jelbourn
approved these changes
Dec 6, 2018
| @@ -5,6 +5,7 @@ load("//tools:defaults.bzl", "ts_library") | |||
| exports_files([ | |||
| "bazel-tsconfig-build.json", | |||
| "bazel-tsconfig-test.json", | |||
| "README.md", | |||
There was a problem hiding this comment.
Not for this PR, but we should create separate npm README files for each of our packages
There was a problem hiding this comment.
Agreed. Should these be pretty much similar to the current one but just have the "correct" package name title and refer to the proper URL for the sources?
There was a problem hiding this comment.
I created an issue and assigned it to myself for this.
* Replaces second "package.json" file with a small workspace that just aliases to the actual dependencies provided in the "@matdeps" workspace. This speeds up the analysis phase and also makes debugging easier.
devversion
force-pushed
the
build/no-longer-require-updating-multiple-package-json-bazel
branch
from
b056693 to
3d8e7d5
Compare
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…el (angular#14391) * Replaces second "package.json" file with a small workspace that just aliases to the actual dependencies provided in the "@matdeps" workspace. This speeds up the analysis phase and also makes debugging easier. * Also proxies the "ng_package" so that it always includes the proper `README.md` file. Also this means that we can always replace the version placeholders. Similar to `angular/angular`. Similar to angular/angular@68074df. Credits to @gregmagolan for this. We just need a bit more work because we don't overwrite the default `compiler`, `xi18n` and `packager` targets to the actual source files (this is special to Angular because those contain the sources)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.mdfile. Also this means that we can always replace the version placeholders. Similar toangular/angular.Similar to angular/angular@68074df. Credits to @gregmagolan for this.
We just need a bit more work because we don't overwrite the default
compiler,xi18nandpackagertargets to the actual source files (this is special to Angular because those contain the sources)