-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: update typescript bazel rules #14465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update typescript bazel rules #14465
Conversation
b13a6f8
to
4aa18c0
Compare
Blocked until there is a new Angular patch release.. Our current Angular version requires v |
* Updates the TypeScript bazel rules to the latest version that includes a hotfix for emit diagnostics not being reported. Also it includes bazelbuild/rules_typescript@f9d6edb which is necessary to build the `src:module-typings` on Windows w/ ng_package.
218ec70
to
ca81bd8
Compare
ca81bd8
to
89d3e6e
Compare
This one is no longer blocked and also includes various TS fixes that weren't detected because of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* build: update typescript bazel rules * Updates the TypeScript bazel rules to the latest version that includes a hotfix for emit diagnostics not being reported. Also it includes bazelbuild/rules_typescript@f9d6edb which is necessary to build the `src:module-typings` on Windows w/ ng_package. * Update to Angular 7.1.3
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
src:module-typings
on Windows w/ ng_package.