Skip to content

build: re-add firebase app types #14476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2018
Merged

build: re-add firebase app types #14476

merged 1 commit into from
Dec 11, 2018

Conversation

devversion
Copy link
Member

@devversion devversion commented Dec 11, 2018 •
edited
Loading

Re-adds the firebase app types which have been removed but are still an optional dependency of firebase-tools.

@devversion devversion added pr: merge safe merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Dec 11, 2018
@devversion devversion requested a review from jelbourn as a code owner December 11, 2018 19:57
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 11, 2018
@devversion
Copy link
Member Author

Should be only merged into master as the 7.1.x branch does still contain the app-types. This should make 7.1.x in sync with master then.

@mmalerba mmalerba added target: minor This PR is targeted for the next minor release action: merge The PR is ready for merge by the caretaker labels Dec 11, 2018
@mmalerba mmalerba merged commit 399019b into angular:master Dec 11, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@devversion @josephperrott
build: re-add firebase app types (angular#14476)
116e453
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @googlebot @mmalerba