Skip to content

fix(material/expansion): picking up lazy content from child component #14477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2022
Merged

fix(material/expansion): picking up lazy content from child component #14477

merged 1 commit into from
Mar 1, 2022

Conversation

crisbeto
Copy link
Member

We use a ContentChild to determine what lazy content to render inside an expansion panel. When the lazy content is nested further down inside another expansion panel, all ancestor panels up the tree will pick up the lowest lazy content from the lowest level. These changes add a check to ensure that the lazy content is rendered out by the closest panel.

Fixes #14365.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 11, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 11, 2018
@crisbeto crisbeto force-pushed the 14365/expansion-panel-child-content branch from fa136cc to 225535d Compare April 3, 2019 21:07
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@andrewseguin andrewseguin added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label May 30, 2019
@crisbeto crisbeto force-pushed the 14365/expansion-panel-child-content branch from 225535d to 92dab0e Compare June 2, 2019 08:38
@crisbeto crisbeto force-pushed the 14365/expansion-panel-child-content branch from 92dab0e to fc46f85 Compare June 20, 2019 21:07
@crisbeto crisbeto force-pushed the 14365/expansion-panel-child-content branch from fc46f85 to d224dcf Compare September 21, 2019 12:58
@josephperrott josephperrott removed their assignment Oct 15, 2019
@crisbeto crisbeto force-pushed the 14365/expansion-panel-child-content branch from d224dcf to 129c9f3 Compare December 31, 2019 06:06
@crisbeto crisbeto force-pushed the 14365/expansion-panel-child-content branch from 129c9f3 to 4e482ba Compare March 11, 2020 22:28
jelbourn
jelbourn approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 13, 2020
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@josephperrott josephperrott removed their request for review April 29, 2021 15:58
@andrewseguin andrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 29, 2021
@crisbeto crisbeto force-pushed the 14365/expansion-panel-child-content branch from 4e482ba to f8c4d28 Compare March 1, 2022 07:46
@crisbeto crisbeto requested review from a team and andrewseguin as code owners March 1, 2022 07:46
@crisbeto crisbeto changed the title fix(expansion-panel): picking up lazy content from child component fix(material/expansion-panel): picking up lazy content from child component Mar 1, 2022
@crisbeto crisbeto force-pushed the 14365/expansion-panel-child-content branch from f8c4d28 to 91aaa06 Compare March 1, 2022 07:46
@crisbeto crisbeto changed the title fix(material/expansion-panel): picking up lazy content from child component fix(material/expansion): picking up lazy content from child component Mar 1, 2022
@crisbeto
fix(material/expansion): picking up lazy content from child component
7dac26d 
We use a `ContentChild` to determine what lazy content to render inside an expansion panel. When the lazy content is nested further down inside another expansion panel, all ancestor panels up the tree will pick up the lowest lazy content from the lowest level. These changes add a check to ensure that the lazy content is rendered out by the closest panel.

Fixes angular#14365.
@crisbeto crisbeto force-pushed the 14365/expansion-panel-child-content branch from 91aaa06 to 7dac26d Compare March 1, 2022 12:29
@crisbeto crisbeto added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 1, 2022
@crisbeto crisbeto merged commit 64c2d31 into angular:master Mar 1, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to lazy render content for specific panel in case of nested expansion panels
6 participants
@crisbeto @jelbourn @googlebot @josephperrott @mmalerba @andrewseguin