Skip to content

chore: correct dependencies in packages config #14542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2018
Merged

chore: correct dependencies in packages config #14542

merged 1 commit into from
Dec 18, 2018

Conversation

crisbeto
Copy link
Member

Fixes cdk-experimental being set up to have a dependency on material, as well as material-experimental having a dependency on cdk-experimental. Also adds cdk and material as dependencies to material-examples.

@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 16, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 16, 2018
@crisbeto
chore: correct dependencies in packages config
b127af9 
Fixes `cdk-experimental` being set up to have a dependency on `material`, as well as `material-experimental` having a dependency on `cdk-experimental`. Also adds `cdk` and `material` as dependencies to `material-examples`.
@crisbeto crisbeto force-pushed the packages-dependencies branch from 17083ea to b127af9 Compare December 16, 2018 22:53
devversion
devversion approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the initial idea was to support that the material-experimental package can import from cdk-experimental. But I agree that it doesn't make sense that cdk-experimental imports from material 😄

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 17, 2018
jelbourn
jelbourn approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

Yeah, material-experimental can import from cdk-experimental, but no need to codify that until we really need it.

@jelbourn jelbourn merged commit 26ff7ec into angular:master Dec 18, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@crisbeto @josephperrott
chore: correct dependencies in packages config (angular#14542)
3d5e458 
Fixes `cdk-experimental` being set up to have a dependency on `material`, as well as `material-experimental` having a dependency on `cdk-experimental`. Also adds `cdk` and `material` as dependencies to `material-examples`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @googlebot