Skip to content

fix(tree): handle null children in nested tree #14547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2018
Merged

fix(tree): handle null children in nested tree #14547

merged 1 commit into from
Dec 18, 2018

Conversation

crisbeto
Copy link
Member

Gracefully handles nodes whose children are set to null. This seems to be something that we used to handle until a regression from #10886.

Fixes #14545.

@crisbeto
fix(tree): handle null children in nested tree
8c7e659 
Gracefully handles nodes whose children are set to null. This seems to be something that we used to handle until a regression from angular#10886.

Fixes angular#14545.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 17, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 17, 2018
jelbourn
jelbourn approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 17, 2018
@jelbourn jelbourn merged commit 364376e into angular:master Dec 18, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@crisbeto @josephperrott
fix(tree): handle null children in nested tree (angular#14547)
bbdd6ba 
Gracefully handles nodes whose children are set to null. This seems to be something that we used to handle until a regression from angular#10886.

Fixes angular#14545.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read property 'forEach' of null (NestedTreeControl)
4 participants
@crisbeto @jelbourn @googlebot @vivian-hu-zz