build: bazel repository changes not cached on circleci #14642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if we update the Bazel `WORKSPACE` and some external repositories have changed, CircleCI won't be able to cache the bazel repositories because the cache-key has not changed and saving will be skipped. We should make sure that the Bazel repositories will be cached properly because otherwise this can cause a significant slow-down with Bazel managed deps. Additionally we no longer store the cache based on the current `branch` because that means that caching does not always work for pull requests. Since the caching only depends on two inputs (yarn.lock and WORKSPACE), it's safe to just remove the branch from the cache key.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
andrewseguin
pushed a commit
that referenced
this pull request
Jan 11, 2019
Currently if we update the Bazel `WORKSPACE` and some external repositories have changed, CircleCI won't be able to cache the bazel repositories because the cache-key has not changed and saving will be skipped. We should make sure that the Bazel repositories will be cached properly because otherwise this can cause a significant slow-down with Bazel managed deps. Additionally we no longer store the cache based on the current `branch` because that means that caching does not always work for pull requests. Since the caching only depends on two inputs (yarn.lock and WORKSPACE), it's safe to just remove the branch from the cache key.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
Currently if we update the Bazel `WORKSPACE` and some external repositories have changed, CircleCI won't be able to cache the bazel repositories because the cache-key has not changed and saving will be skipped. We should make sure that the Bazel repositories will be cached properly because otherwise this can cause a significant slow-down with Bazel managed deps. Additionally we no longer store the cache based on the current `branch` because that means that caching does not always work for pull requests. Since the caching only depends on two inputs (yarn.lock and WORKSPACE), it's safe to just remove the branch from the cache key.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if we update the Bazel
WORKSPACEand some external repositories have changed, CircleCI won't be able to cache the bazel repositories because the cache-key has not changed and saving will be skipped. We should make sure that the Bazel repositories will be cached properly because otherwise this can cause a significant slow-down with Bazel managed deps.Additionally we no longer store the cache based on the current
branchbecause that means that caching does not always work for pull requests. Since the caching only depends on two inputs (yarn.lock and WORKSPACE), it's safe to just remove the branch from the cache key.