Skip to content

fix(drag-drop): standalone draggable drag class not being applied with OnPush change detection #14727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 4, 2019

Fixes the styling that is applied while an item is dragged not being applied with OnPush change detection.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 4, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 4, 2019
@crisbeto crisbeto force-pushed the drag-styling-on-push branch from 31dc628 to 9c19693 Compare January 4, 2019 19:51
@crisbeto crisbeto force-pushed the drag-styling-on-push branch from 9c19693 to 20221f4 Compare January 5, 2019 07:05
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 9, 2019
@crisbeto crisbeto force-pushed the drag-styling-on-push branch 2 times, most recently from 047e3a6 to 432df63 Compare January 17, 2019 23:13
@ngbot
Copy link

ngbot bot commented Jan 25, 2019

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

…h OnPush change detection

Fixes the styling that is applied while an item is dragged not being applied with `OnPush` change detection.
@crisbeto crisbeto force-pushed the drag-styling-on-push branch from 432df63 to b80b33b Compare January 27, 2019 17:24
@jelbourn jelbourn merged commit 8ddcb5b into angular:master Feb 7, 2019
jelbourn pushed a commit that referenced this pull request Feb 11, 2019
…h OnPush change detection (#14727)

Fixes the styling that is applied while an item is dragged not being applied with `OnPush` change detection.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants