Skip to content

chore: add yarn format command and pre-commit hook to ensure code is formatted #15132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2019
Merged

chore: add yarn format command and pre-commit hook to ensure code is formatted #15132

merged 1 commit into from
Feb 9, 2019

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Feb 8, 2019

No description provided.

@mmalerba mmalerba requested a review from jelbourn February 8, 2019 21:05
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 8, 2019
jelbourn
jelbourn approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 8, 2019
@jelbourn jelbourn merged commit 57aadc2 into angular:master Feb 9, 2019
jelbourn pushed a commit that referenced this pull request Feb 11, 2019
@mmalerba @jelbourn
chore: add yarn format command and pre-commit hook to ensure code i…
7c832fd 
…s formatted (#15132)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalerba @jelbourn @googlebot