fix(material/menu): use narrower value for aria-haspopup on trigger element #15219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
Accessibility
crisbeto
force-pushed
the
menu-aria-haspopup
branch
from
828e2c2 to
b156f89
Compare
crisbeto
force-pushed
the
menu-aria-haspopup
branch
2 times, most recently
from
39c32f3 to
f20a2aa
Compare
crisbeto
changed the title
crisbeto
force-pushed
the
menu-aria-haspopup
branch
from
f20a2aa to
4864763
Compare
andrewseguin
added
needs rebase
and removed
cla: yes
crisbeto
force-pushed
the
menu-aria-haspopup
branch
from
4864763 to
c28a26e
Compare
…lement Currently we set `aria-haspopup` correctly on the menu trigger, however [according to the spec](https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup) we can narrow the value down so that it indicates what kind of popup will be opened.
crisbeto
force-pushed
the
menu-aria-haspopup
branch
from
c28a26e to
f9195ad
Compare
crisbeto
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we set
aria-haspopupcorrectly on the menu trigger, however according to the spec we can narrow the value down so that it indicates what kind of popup will be opened.