Skip to content

unsubscribe some subscriptions on destroy / first some subscriptions #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 20, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/lib/core/line/line.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ export class MdLineSetter {
});
}


private _setLineClass(count: number): void {
this._resetClasses();
if (count === 2 || count === 3) {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/dialog/dialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export class MdDialog {
let dialogRef = <MdDialogRef<T>> new MdDialogRef(overlayRef);

// When the dialog backdrop is clicked, we want to close it.
overlayRef.backdropClick().subscribe(() => dialogRef.close());
overlayRef.backdropClick().first().subscribe(() => dialogRef.close());

// Set the dialogRef to the container so that it can use the ref to close the dialog.
dialogContainer.dialogRef = dialogRef;
Expand Down
4 changes: 2 additions & 2 deletions src/lib/icon/icon.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,11 @@ export class MdIcon implements OnChanges, OnInit, AfterViewChecked {
if (changedInputs.indexOf('svgIcon') != -1 || changedInputs.indexOf('svgSrc') != -1) {
if (this.svgIcon) {
const [namespace, iconName] = this._splitIconName(this.svgIcon);
this._mdIconRegistry.getNamedSvgIcon(iconName, namespace).subscribe(
this._mdIconRegistry.getNamedSvgIcon(iconName, namespace).first().subscribe(
svg => this._setSvgElement(svg),
(err: any) => console.log(`Error retrieving icon: ${err}`));
} else if (this.svgSrc) {
this._mdIconRegistry.getSvgIconFromUrl(this.svgSrc).subscribe(
this._mdIconRegistry.getSvgIconFromUrl(this.svgSrc).first().subscribe(
svg => this._setSvgElement(svg),
(err: any) => console.log(`Error retrieving icon: ${err}`));
}
Expand Down
1 change: 0 additions & 1 deletion src/lib/sidenav/sidenav.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ export class MdSidenav {
/** Event emitted when the sidenav is fully closed. */
@Output('close') onClose = new EventEmitter<void>();


/**
* @param _elementRef The DOM element reference. Used for transition and width calculation.
* If not available we do not hook on transitions.
Expand Down