Skip to content

chore: create separate modules for each demo page #15498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 15, 2019
Merged

chore: create separate modules for each demo page #15498

merged 3 commits into from
Mar 15, 2019

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe target: patch This PR is targeted for the next patch release labels Mar 15, 2019
@mmalerba mmalerba requested a review from andrewseguin March 15, 2019 20:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 15, 2019
crisbeto
crisbeto reviewed Mar 15, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, but is there any context as to why we're doing it?

@andrewseguin
Copy link
Contributor

LGTM

@mmalerba
Copy link
Contributor Author

@crisbeto This is a step toward having lazy-loadable routes, which will make our dev-app load faster and give us a place to reproduce lazy-loading bugs reported by users

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Mar 15, 2019
crisbeto
crisbeto approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 3b0f7fc into angular:master Mar 15, 2019
mmalerba added a commit that referenced this pull request Mar 18, 2019
@mmalerba
chore: create separate modules for each demo page (#15498)
f503353
mmalerba added a commit that referenced this pull request Mar 18, 2019
@mmalerba
chore: create separate modules for each demo page (#15498)
54733f0
@mmalerba mmalerba mentioned this pull request Mar 19, 2019
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @andrewseguin @crisbeto @googlebot