Skip to content

build: source maps for some dependencies not exposed during unit tests #16104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2019

Conversation

crisbeto
Copy link
Member

Fixes the source maps for all the @material dependencies, as well as hammer, core.js and systemjs not being served during unit tests.

@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels May 23, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 23, 2019
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 23, 2019
Fixes the source maps for all the `@material` dependencies, as well as `hammer`, `core.js` and `systemjs` not being served during unit tests.
@crisbeto crisbeto force-pushed the test-dep-source-maps branch from e0c9433 to 5fef4dc Compare May 24, 2019 05:35
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I always turn off my JS sourcemaps in devtools, though. I find that it's easier to debug that way.

@mmalerba mmalerba merged commit f34bf7e into angular:master May 24, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
angular#16104)

Fixes the source maps for all the `@material` dependencies, as well as `hammer`, `core.js` and `systemjs` not being served during unit tests.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants