-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: fill in missing MATERIAL_EXPERIMENTAL_PACKAGES #16113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mmalerba I see the point of doing this but I'm slightly afraid that this adds additional bloat to our build definitions and I'd personally advocate for just using e.g.
We could make shortcuts for these in the I don't think its worth having an additional tag for unit tests though |
Ah cool, I didn't realize that was a thing. I like that better too. I fixed a couple random issues with the BUILD files while I was doing this, so I'll re-purpose this PR for fixing those and then just use the tags as you suggested for separating the tests |
@devversion PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I noticed that the MDC components were missing from MATERIAL_EXPERIMENTAL_PACKAGES. This PR fixes it and does some related cleanup