Skip to content

feat(a11y): allow for element to be used as message in AriaDescriber #16118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2019
Merged

feat(a11y): allow for element to be used as message in AriaDescriber #16118

merged 1 commit into from
Jun 7, 2019

Conversation

crisbeto
Copy link
Member

  • Adds the ability to pass in an existing element as the message to AriaDescriber.describe.
  • Removes the @docs-private from the AriaDescriber so that it's available in the API docs.

Fixes #16099.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 25, 2019
@crisbeto
feat(a11y): allow for element to be used as message in AriaDescriber
a84bd5d 
* Adds the ability to pass in an existing element as the message to `AriaDescriber.describe`.
* Removes the `@docs-private` from the `AriaDescriber` so that it's available in the API docs.

Fixes angular#16099.
@crisbeto crisbeto force-pushed the 16099/aria-describer-element branch from a845b82 to a84bd5d Compare May 25, 2019 07:40
@crisbeto crisbeto added G This is is related to a Google internal issue target: minor This PR is targeted for the next minor release labels May 25, 2019
@crisbeto crisbeto marked this pull request as ready for review May 25, 2019 08:03
@andrewseguin andrewseguin added the P2 The issue is important to a large percentage of users, with a workaround label May 30, 2019
jelbourn
jelbourn approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 30, 2019
@jelbourn
Copy link
Member

cc @mertdeg2

@josephperrott josephperrott merged commit 8c4f25f into angular:master Jun 7, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@crisbeto @RudolfFrederiksen
feat(a11y): allow for element to be used as message in AriaDescriber (a…
1e8377b 
…ngular#16118)

* Adds the ability to pass in an existing element as the message to `AriaDescriber.describe`.
* Removes the `@docs-private` from the `AriaDescriber` so that it's available in the API docs.

Fixes angular#16099.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AriaDescriber should let us describe elements via other DOM Elements (as well as just string)
5 participants
@crisbeto @jelbourn @googlebot @josephperrott @andrewseguin