Skip to content

feat(youtube-player): initialize component and infrastructure #16337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2019
Merged

feat(youtube-player): initialize component and infrastructure #16337

merged 1 commit into from
Jul 31, 2019

Conversation

YourDeveloperFriend
Copy link
Collaborator

No description provided.

@googlebot

This comment has been minimized.

Sign in to view
@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jun 20, 2019
@googlebot

This comment has been minimized.

Sign in to view
@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jun 20, 2019
jelbourn
jelbourn reviewed Jun 20, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick first pass

@YourDeveloperFriend YourDeveloperFriend force-pushed the rebase branch 3 times, most recently from b418b76 to dbc26ac Compare June 26, 2019 21:18
@YourDeveloperFriend YourDeveloperFriend force-pushed the rebase branch 9 times, most recently from 2edb23f to 963b31d Compare July 24, 2019 17:48
jelbourn
jelbourn reviewed Jul 24, 2019
View reviewed changes
@jelbourn jelbourn requested a review from crisbeto July 24, 2019 19:13
@jelbourn jelbourn added the G This is is related to a Google internal issue label Jul 24, 2019
@jelbourn
Copy link
Member

Let me know when the PR is ready for another round; GitHub doesn't have a great mechanism for saying "ready to go"

devversion
devversion reviewed Jul 25, 2019
View reviewed changes
@YourDeveloperFriend
Copy link
Collaborator Author

This PR is ready for review.

jelbourn
jelbourn approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker pr: merge safe target: minor This PR is targeted for the next minor release labels Jul 31, 2019
@jelbourn jelbourn merged commit b8c9da6 into angular:master Jul 31, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion left review comments

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YourDeveloperFriend @googlebot @jelbourn @devversion