test: rework flaky tests that depend on getComputedStyle #16487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
requested review from
andrewseguin,
jelbourn and
mmalerba
as code owners
crisbeto
added
P2
Currently most of the grid list tests as well as one of tab nav bar test are flaky, because we use `getComputedStyle` for assertions and the return values can be formatted differently depending on the browser. These changes move them to either pick up values directly from the DOM or to measure the element with `getBoundingClientRect`.
crisbeto
force-pushed
the
get-computed-style-test-flakes
branch
from
db5d3bc to
8c6869d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently most of the grid list tests as well as one of tab nav bar test are flaky, because we use
getComputedStylefor assertions and the return values can be formatted differently depending on the browser. These changes move them to either pick up values directly from the DOM or to measure the element withgetBoundingClientRect.