Skip to content

build: allow inspecting test nodejs process w/ bazel #16525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

Adds a new debug configuration for Bazel that can be used to
open the Chrome Devtools Debugger in order to debug a bazel
test that runs with NodeJS. This is similar to what angular/angular
provides.

Note: This does not make debugging for web test suites easier. For
web test suites we need to find a better solution. I have something in mind
where developers can run bazel run instead of bazel test to open the
karma test suite in non-capture mode (allowing easy debugging)

Adds a new `debug` configuration for Bazel that can be used to
open the Chrome Devtools Debugger in order to debug a bazel
test that runs with NodeJS. This is similar to what `angular/angular`
provides.

*Note*: This does not make debugging for web test suites easier. For
web test suites we need to find a better solution. I have something in mind
where developers can run `bazel run` instead of `bazel test` to open the
karma test suite in non-capture mode (allowing easy debugging)
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Jul 15, 2019
@devversion devversion requested a review from jelbourn as a code owner July 15, 2019 20:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 15, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 16, 2019
@jelbourn jelbourn merged commit 40ad0fc into angular:master Jul 16, 2019
jelbourn pushed a commit that referenced this pull request Jul 16, 2019
Adds a new `debug` configuration for Bazel that can be used to
open the Chrome Devtools Debugger in order to debug a bazel
test that runs with NodeJS. This is similar to what `angular/angular`
provides.

*Note*: This does not make debugging for web test suites easier. For
web test suites we need to find a better solution. I have something in mind
where developers can run `bazel run` instead of `bazel test` to open the
karma test suite in non-capture mode (allowing easy debugging)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants