feat(select): allow for letter key debounce interval to be customized #16579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
reviewed
Jul 23, 2019
src/material/select/select.ts
Outdated
| @@ -426,6 +426,9 @@ export class MatSelect extends _MatSelectMixinBase implements AfterContentInit, | |||
| /** Object used to control when error messages are shown. */ | |||
| @Input() errorStateMatcher: ErrorStateMatcher; | |||
|
|
|||
| /** Time to wait in milliseconds after the last keystroke before moving focus to an item. */ | |||
| @Input() letterKeyDebounceInterval: number; | |||
There was a problem hiding this comment.
As a public API, "letterKey" seems a little too much like an implementation detail. How about typeaheadDebounceInterval?
There was a problem hiding this comment.
Sure, that sounds better. Changed.
crisbeto
force-pushed
the
16472/select-debounce-interval
branch
from
ada3638 to
687b68e
Compare
Allows the consumer to customize the letter key debounce interval. This can be useful for some cases where the values are harder to type quickly (e.g. ZIP codes). Fixes angular#16472.
crisbeto
force-pushed
the
16472/select-debounce-interval
branch
from
687b68e to
19745fb
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the consumer to customize the letter key debounce interval. This can be useful for some cases where the values are harder to type quickly (e.g. ZIP codes).
Fixes #16472.