Skip to content

feat(material-experimental): add test harness for radio-button #16593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Adds a test harness for the MatRadioButton implementation. Even though there
is no implementation of radio w/ MDC, the standard harness and tests are helpful and
reduce work that is needed to create a MDC prototype of radio.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Jul 24, 2019
@devversion devversion requested a review from mmalerba as a code owner July 24, 2019 11:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 24, 2019
Adds a test harness for the `MatRadioButton` implementation. Even though there
is no implementation of radio w/ MDC, the standard harness and tests are helpful and
reduce work that is needed to create a MDC prototype of radio.
@devversion devversion force-pushed the fea/material-experimental-radio-harness branch from f7e4df3 to 0346253 Compare July 24, 2019 11:41
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do you plan on doing MatRadioButtonGroup in a follow-up PR?

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 24, 2019
@jelbourn jelbourn merged commit 583af19 into angular:master Jul 24, 2019
andrewseguin pushed a commit that referenced this pull request Jul 29, 2019
Adds a test harness for the `MatRadioButton` implementation. Even though there
is no implementation of radio w/ MDC, the standard harness and tests are helpful and
reduce work that is needed to create a MDC prototype of radio.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants