fix(material/autocomplete): don't reset active option if list of options changes #16616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
16608/autocomplete-option-change-reset
branch
from
2fd76ac to
f9294f0
Compare
andrewseguin
added
presubmit failures
|
Presubmit failures - Looks like some tests rely on the fact that they can insert options after the panel is opened and expect the first item to be active. This is not the case now that option changes do not activate the first item |
andrewseguin
removed
the
cla: yes
…ons changes Currently we reset the active option whenever the list of items changes, however this means that the user's selection could be lost while they're interacting, if some items get added to the end of the list out of view (e.g. if the options are fetched via polling). These changes address the issue by only resetting the active option when the panel is opened. Fixes angular#16608.
crisbeto
force-pushed
the
16608/autocomplete-option-change-reset
branch
from
f9294f0 to
01209a2
Compare
crisbeto
changed the title
crisbeto
added
action: merge
|
I've rebased this and come up with a different approach to try and minimize presubmit issues. Will run another presubmit to verify. |
|
The alternate approach broke a bunch of clients, because the first option no longer gets activated after the user filters the list. |
andrewseguin
added
needs rebase
and removed
P3
josephperrott
added
action: cleanup
josephperrott
requested review from
amysorto and
mmalerba
and removed request for
a team
mmalerba
added
presubmit failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we reset the active option whenever the list of items changes, however this means that the user's selection could be lost while they're interacting, if some items get added to the end of the list out of view (e.g. if the options are fetched via polling).
These changes address the issue by only resetting the active option when the panel is opened.
Fixes #16608.