move some things from cdk/testing to cdk/private/testing #16621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is in preparation for when we publish cdk/testing with the component harness infrastructure
mmalerba
requested review from
andrewseguin,
crisbeto,
devversion and
josephperrott
as code owners
googlebot
added
the
cla: yes
crisbeto
reviewed
Jul 27, 2019
There was a problem hiding this comment.
Rather than calling it internal-testing, should we make something similar to the @angular/private/testing from angular/angular?
|
That sounds good as long as it works. I know some of our scripts don't really expect to deal with tertiary entry points, but it might be ok since we're not publishing it. I'll try putting it under |
mmalerba
changed the title
devversion
approved these changes
Jul 29, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for when we publish cdk/testing with the component harness infrastructure. cdk/private/testing will be an unpublished package that we use for our own shared testing utilities.
I've also added
@docs-privateto all symbols that remain in cdk/testing. They are not really intended to be used directly (at least not until we review the API and add docs and tests), instead they will be used by the harness infrastructure which will be a public API.