feat(material-experimental): add option to filter checkbox harnesses by name #16662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
added
pr: merge safe
target: patch
mmalerba
reviewed
Aug 12, 2019
src/material-experimental/mdc-checkbox/harness/checkbox-harness.ts
Outdated
Show resolved
Hide resolved
mmalerba
approved these changes
Aug 12, 2019
|
apply merge ready after updating comment |
…by name Adds an option to the checkbox harnesses that allows developers to filter harnesses by checkbox names. This is helpful because developers can not filter checkboxes by name using CSS selectors because the `name` input binding is not bound to the host DOM element. Similar to angular#16609 (comment)
devversion
force-pushed
the
feat/material-experimental-checkbox-filter-by-name-harness
branch
from
4ae87f7 to
1f678e6
Compare
mmalerba
pushed a commit
that referenced
this pull request
Aug 14, 2019
Adds an option to the checkbox harnesses that allows developers to filter harnesses by checkbox names. This is helpful because developers can not filter checkboxes by name using CSS selectors because the `name` input binding is not bound to the host DOM element. Similar to #16609 (comment) (cherry picked from commit 2cbabf0)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to the checkbox harnesses that allows developers
to filter harnesses by checkbox names. This is helpful because
developers can not filter checkboxes by name using CSS selectors
because the
nameinput binding is not bound to the host DOM element.Similar to #16609 (comment)