build: cronjob to run tests against mdc snapshot builds #16668
Conversation
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/snapshot-cronjob-mdc-master
branch
6 times, most recently
from
01730d9 to
846962b
Compare
devversion
force-pushed
the
build/snapshot-cronjob-mdc-master
branch
from
846962b to
c387230
Compare
devversion
added
pr: merge safe
target: patch
devversion
force-pushed
the
build/snapshot-cronjob-mdc-master
branch
from
c387230 to
5a1fa33
Compare
|
LGTM, but it might be good if @jelbourn takes a look, I don't really know what I'm looking at 😅 |
| environment: | ||
| GCP_DECRYPT_TOKEN: *gcp_decrypt_token | ||
| MDC_REPO_URL: "https://github.com/material-components/material-components-web.git" | ||
| MDC_REPO_BRANCH: "master" |
There was a problem hiding this comment.
I found out on Friday that MDC's development HEAD is actually a branch called develop instead of master, so I believe we should test that
cc @abhiomkar
There was a problem hiding this comment.
Yeah this document describes that develop includes breaking-changes. Though I'm not sure which one we want to pick. It looks like both do not really intersect. e.g. a non-breaking change is not merged into both master and develop (based on my observation on the repo)
| name: "Installing dependencies for MDC repository" | ||
| # MDC repository does not use Yarn for node dependencies, so in order to respec the | ||
| # lock-file we need to use "npm" when installing dependencies. | ||
| command: cd ${MDC_REPO_TMP_DIR} && npm install |
There was a problem hiding this comment.
@abhiomkar have you all considered switching to yarn? We've generally found that the locking mechanism works better (especially WRT remote caching and the bazel stuff we do)
Sets up a new cronjob that runs tests against the `material-components-web` repository HEAD. This allows us to validate that our MDC components work properly with upcoming MDC releases.
devversion
force-pushed
the
build/snapshot-cronjob-mdc-master
branch
from
5a1fa33 to
b29c03f
Compare
jelbourn
added
pr: lgtm
action: merge
Sets up a new cronjob that runs tests against the `material-components-web` repository HEAD. This allows us to validate that our MDC components work properly with upcoming MDC releases. (cherry picked from commit 258ca59)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sets up a new cronjob that runs tests against the
material-components-webrepository HEAD. This allows us to validate that our MDC components work
properly with upcoming MDC releases.