Skip to content

build: update to 8.2.0 and TypeScript 3.5.3 #16678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2019
Merged

build: update to 8.2.0 and TypeScript 3.5.3 #16678

merged 1 commit into from
Aug 13, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 4, 2019

Bumps all of the Angular dependencies to 8.2.0 so that we can update to TypeScript 3.5+ and take advantage of the build speed improvements.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 4, 2019
@crisbeto crisbeto force-pushed the angular-8.2.0 branch 5 times, most recently from c1522a9 to f1a4af2 Compare August 4, 2019 08:17
crisbeto
crisbeto commented Aug 4, 2019
View reviewed changes
package.json
"@angular-devkit/core": "^8.0.3",
"@angular-devkit/schematics": "^8.0.3",
"@angular-devkit/core": "^8.2.0",
"@angular-devkit/schematics": "^8.2.0",
"@angular/bazel": "^8.1.0",
Copy link
Member Author

@crisbeto crisbeto Aug 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I wanted to bump the Bazel dependencies as well, but updating @angular/bazel causes only the CI to throw an error along the lines of Cannot find command bazel. It only happens on the CI and the error wasn't super helpful so I wasn't able to track it down. My best guess is that it might be something with the setup_bazel_binary.sh.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @angular/bazel package should not be related to the bazel binary at all. Should we just get this PR through and I'll have a look at the Bazel related thing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@crisbeto crisbeto marked this pull request as ready for review August 4, 2019 08:44
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Aug 4, 2019
devversion
devversion approved these changes Aug 4, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One comment for a confusing type cast.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 4, 2019
jelbourn
jelbourn approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs rebase

@crisbeto @mmalerba
build: update to 8.2.0 and TypeScript 3.5.3
26ae3f8 
Bumps all of the Angular dependencies to 8.2.0 so that we can update to TypeScript 3.5+ and take advantage of the build speed improvements.
@mmalerba mmalerba merged commit 1f0ab1b into angular:master Aug 13, 2019
devversion added a commit to devversion/material2 that referenced this pull request Aug 13, 2019
@devversion
build: update to angular v8.2.2
f648860 
* Updates to Angular v8.2.2
* Updates the bazel tooling to the latest version (as discussed in angular#16678)
@devversion devversion mentioned this pull request Aug 13, 2019
Merged
devversion added a commit to devversion/material2 that referenced this pull request Aug 13, 2019
@devversion
build: update to angular v8.2.2
db4a168 
* Updates to Angular v8.2.2
* Updates the bazel tooling to the latest version (as discussed in angular#16678)
jelbourn pushed a commit that referenced this pull request Aug 13, 2019
@devversion @jelbourn
build: update to angular v8.2.2 (#16763)
1d6682c 
* Updates to Angular v8.2.2
* Updates the bazel tooling to the latest version (as discussed in #16678)
mmalerba pushed a commit that referenced this pull request Aug 14, 2019
@crisbeto @mmalerba
build: update to 8.2.0 and TypeScript 3.5.3 (#16678)
688d3f4 
Bumps all of the Angular dependencies to 8.2.0 so that we can update to TypeScript 3.5+ and take advantage of the build speed improvements.

(cherry picked from commit 1f0ab1b)
mmalerba pushed a commit that referenced this pull request Aug 14, 2019
@devversion @mmalerba
build: update to angular v8.2.2 (#16763)
0ec2e56 
* Updates to Angular v8.2.2
* Updates the bazel tooling to the latest version (as discussed in #16678)

(cherry picked from commit 1d6682c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

@devversion devversion

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crisbeto @jelbourn @devversion @googlebot @josephperrott @mmalerba