-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Update MDC to latest alpha #16724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MDC to latest alpha #16724
Conversation
FYI @vanessanschmitt most of the changes are related to mdc-chips, you may want to sanity check the demo link above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 8942602.
* update MDC version * fix errors * fix lint (cherry picked from commit 8942602)
* Revert "Revert "Update MDC to latest alpha (#16724)" (#16770)" This reverts commit cc8f37f. * minor tweak to mdc chips adapter for latest upstream update to unbreak pantheon angular already manages focus fully and this hook does negligible good and a lot of harm (e.g., focusing thigns that were never meant to be focused). long term we probably want to consolidate the code, but for now just keep it unbroken. squash this commit into the main PR
* Revert "Revert "Update MDC to latest alpha (#16724)" (#16770)" This reverts commit cc8f37f. * minor tweak to mdc chips adapter for latest upstream update to unbreak pantheon angular already manages focus fully and this hook does negligible good and a lot of harm (e.g., focusing thigns that were never meant to be focused). long term we probably want to consolidate the code, but for now just keep it unbroken. squash this commit into the main PR (cherry picked from commit 3aa5ca4)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
before this change: https://mmalerba-demo1.firebaseapp.com/mdc-chips
after this change: https://mmalerba-demo2.firebaseapp.com/mdc-chips