Skip to content

Update MDC to latest alpha #16724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2019
Merged

Update MDC to latest alpha #16724

merged 3 commits into from
Aug 12, 2019

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Aug 8, 2019

@mmalerba mmalerba requested a review from jelbourn August 8, 2019 21:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 8, 2019
@mmalerba
Copy link
Contributor Author

mmalerba commented Aug 8, 2019

FYI @vanessanschmitt most of the changes are related to mdc-chips, you may want to sanity check the demo link above

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Aug 8, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 8, 2019
Copy link
Collaborator

@vanessanschmitt vanessanschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 8942602 into angular:master Aug 12, 2019
@mmalerba mmalerba deleted the mdc-update branch August 12, 2019 23:10
mmalerba added a commit to mmalerba/components that referenced this pull request Aug 13, 2019
mmalerba added a commit that referenced this pull request Aug 13, 2019
mmalerba added a commit that referenced this pull request Aug 13, 2019
mmalerba added a commit that referenced this pull request Aug 14, 2019
* update MDC version

* fix errors

* fix lint

(cherry picked from commit 8942602)
mmalerba added a commit that referenced this pull request Aug 14, 2019
This reverts commit 8942602.

(cherry picked from commit cc8f37f)
devversion pushed a commit to devversion/material2 that referenced this pull request Aug 16, 2019
devversion pushed a commit to devversion/material2 that referenced this pull request Aug 16, 2019
mmalerba added a commit that referenced this pull request Aug 21, 2019
* Revert "Revert "Update MDC to latest alpha (#16724)" (#16770)"

This reverts commit cc8f37f.

* minor tweak to mdc chips adapter for latest upstream update to unbreak pantheon

angular already manages focus fully and this hook does negligible good and a lot of harm (e.g., focusing thigns that were never meant to be focused). long term we probably want to consolidate the code, but for now just keep it unbroken.

squash this commit into the main PR
andrewseguin pushed a commit that referenced this pull request Aug 26, 2019
* Revert "Revert "Update MDC to latest alpha (#16724)" (#16770)"

This reverts commit cc8f37f.

* minor tweak to mdc chips adapter for latest upstream update to unbreak pantheon

angular already manages focus fully and this hook does negligible good and a lot of harm (e.g., focusing thigns that were never meant to be focused). long term we probably want to consolidate the code, but for now just keep it unbroken.

squash this commit into the main PR

(cherry picked from commit 3aa5ca4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants