Skip to content

build: do not run ngc postinstall on schematics #16758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

devversion
Copy link
Member

@devversion devversion commented Aug 12, 2019

Unblocks angular/angular#31650 as we don't want to post-process the schematic migration code that might have type imports to @angular/compiler-cli.

These imports can break due to entry-point issues as angular/angular#29220

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Aug 12, 2019
@devversion devversion requested a review from jelbourn as a code owner August 12, 2019 19:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 12, 2019
@devversion devversion added the P2 The issue is important to a large percentage of users, with a workaround label Aug 12, 2019
@mmalerba mmalerba merged commit 097f433 into angular:master Aug 12, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 12, 2019
mmalerba pushed a commit that referenced this pull request Aug 14, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants