-
Notifications
You must be signed in to change notification settings - Fork 6.8k
prototype(slider): create prototype slider based on MDC web #16795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6d263de
to
e2e74b0
Compare
I think MDC is planning to redo the slider at some point because the visual style has updated in the spec. If they're planning to also revisit the API and supported features at that time it may make sense to wait on this one. @abhiomkar do you know if there are any plans to change the API when updating the visual style? |
@mmalerba I had a look at their slider branch which I assumed was for the mentioned rework and it looked like most of the things remained the same and just a few public-facing foundation/adapter changes were done. Happy to wait for the rework to land though. I just didn't think the rework will happen anytime soon and if it lands, we can re-use this work as most of the things should remain the same. https://github.com/material-components/material-components-web/commits/feat/slider (last commit Aug 2018; unless there is a different branch) |
Slider refactor is not planned in this quarter. |
Ok, sounds like we can just go ahead with this for now |
2f295ba
to
a34ca48
Compare
}); | ||
|
||
// TODO: MDC slider does not respect modifier keys. | ||
// tslint:disable-next-line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File a bug on their repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's by intention that they don't respect modifier keys. Native range sliders don't seem to respect these either (i.e. value still changes with SHIFT + LEFT ARROW).
How should we proceed? based on their implementation of the keyboard logic we can't overwrite/configure this behavior.
a34ca48
to
ed3b09b
Compare
@jelbourn Feedback addressed. Created the issues on the MDC repository and updated the feature comparison doc accordingly. |
ed3b09b
to
9364dca
Compare
Should be unblocked now that the chips changes are in |
Yes. thanks @mmalerba for updating the label. |
@jelbourn can you have another look at this PR when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments
9364dca
to
d07868f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d07868f
to
f1266fa
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Creates a prototype of
mat-slider
that uses MDC web. The feature comparison document has been filled.A list of notable bugs in the MDC foundation right now:
input
events; workaround applied)mouseenter
.Notable feature differences:
Currently blocked on #16772.