build: add blocklist to disable individual tests in the project #16833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
Similarly to what we had in the `ivy-2019` branch for disabling individual tests, we now need something similar that works with Bazel. This is necessary because there are still breaking changes that could land in the framework repository and break individual tests of the component repository. Framework now needs a way to disable those specific tests until the components repository migrated the broken tests (this can be delayed by weeks since the breaking change is not necessarily yet released)
devversion
force-pushed
the
build/blocklist-test-support
branch
from
4de4e3b to
69999d7
Compare
devversion
added a commit
to devversion/angular
that referenced
this pull request
Aug 21, 2019
Initially the blocklist has been removed because there were no remaining disabled tests that failed. Also the blocklist logic didn't work anymore because the `material-unit-tests` CI job now runs against `angular/components#master` with Bazel. 388578f tried to revert the removal of the blocklist in favor of a new upcoming breaking change with HammerJS, but the revert doesn't help since the blocklist still doesn't work with Bazel. In order to make the blocklist work with the unit tests running with Bazel, a PR has been submitted on the components repository. See: angular/components#16833. This commit updates the blocklist logic on the framework side to work with the new logic on the components repo side.
devversion
added
the
P2
josephperrott
approved these changes
Aug 21, 2019
josephperrott
approved these changes
Aug 21, 2019
| * repository. It should be possible to disable these tests until the component repository | ||
| * migrated the broken tests. | ||
| */ | ||
| export const testBlocklist: {[testName: string]: Object} = {}; |
There was a problem hiding this comment.
Should this be BlocklistEntry like we have in Framework?
There was a problem hiding this comment.
Good question. I decided not to do that as on the components side we are not interested in notes or error message but rather just in the list of disabled tests.
Happy to change though. I don't feel too strong 😄
Also there would be no benefit for us on the components side and framework side. Just duplication IMO
There was a problem hiding this comment.
Whichever way is fine with me, we can leave it. Its a temporary piece anyway that we shouldn't need for a long time anyway.
josephperrott
added
pr: lgtm
action: merge
AndrewKushnir
pushed a commit
to angular/angular
that referenced
this pull request
Aug 21, 2019
Initially the blocklist has been removed because there were no remaining disabled tests that failed. Also the blocklist logic didn't work anymore because the `material-unit-tests` CI job now runs against `angular/components#master` with Bazel. 388578f tried to revert the removal of the blocklist in favor of a new upcoming breaking change with HammerJS, but the revert doesn't help since the blocklist still doesn't work with Bazel. In order to make the blocklist work with the unit tests running with Bazel, a PR has been submitted on the components repository. See: angular/components#16833. This commit updates the blocklist logic on the framework side to work with the new logic on the components repo side. PR Close #32239
andrewseguin
pushed a commit
that referenced
this pull request
Aug 26, 2019
Similarly to what we had in the `ivy-2019` branch for disabling individual tests, we now need something similar that works with Bazel. This is necessary because there are still breaking changes that could land in the framework repository and break individual tests of the component repository. Framework now needs a way to disable those specific tests until the components repository migrated the broken tests (this can be delayed by weeks since the breaking change is not necessarily yet released) (cherry picked from commit 18b9ef3)
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
Initially the blocklist has been removed because there were no remaining disabled tests that failed. Also the blocklist logic didn't work anymore because the `material-unit-tests` CI job now runs against `angular/components#master` with Bazel. 388578f tried to revert the removal of the blocklist in favor of a new upcoming breaking change with HammerJS, but the revert doesn't help since the blocklist still doesn't work with Bazel. In order to make the blocklist work with the unit tests running with Bazel, a PR has been submitted on the components repository. See: angular/components#16833. This commit updates the blocklist logic on the framework side to work with the new logic on the components repo side. PR Close angular#32239
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to what we had in the
ivy-2019branch for disablingindividual tests, we now need something similar that works with
Bazel. This is necessary because there are still breaking changes
that could land in the framework repository and break individual
tests of the component repository.
Framework now needs a way to disable those specific tests until
the components repository migrated the broken tests (this can
be delayed by weeks since the breaking change is not necessarily
yet released)