Skip to content

build: re-enable disabled gesture config test #16845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

@devversion devversion commented Aug 22, 2019

eaf70ca temporarily disabled the gesture config tests because the blocklist
didn't work. Now that the blocklist works on the framework side, we can
re-enable this test again.

Once this PR lands, we can update the SHA on the framework repo and
add the gesture tests to the blocklist.

cc. @kara

eaf70ca temporarily disabled the gesture
config tests because the blocklist didn't work. Now that the blocklist works on
the framework side, we can re-enable this test again.

Once this PR lands, we can update the SHA on the framework repo and
add the gesture tests to the blocklist.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Aug 22, 2019
@devversion devversion requested a review from jelbourn as a code owner August 22, 2019 15:42
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 22, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 22, 2019
@jelbourn jelbourn merged commit fa81811 into angular:master Aug 22, 2019
andrewseguin pushed a commit that referenced this pull request Aug 26, 2019
eaf70ca temporarily disabled the gesture
config tests because the blocklist didn't work. Now that the blocklist works on
the framework side, we can re-enable this test again.

Once this PR lands, we can update the SHA on the framework repo and
add the gesture tests to the blocklist.

(cherry picked from commit fa81811)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants