feat(sort): remove hammer dependency #16951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
These changes remove the dependency on Hammer.js from the `matSortHeader`. I decided to remove the `longpress` gesture, rather than implement it with vanilla JS, because it doesn't look like it's worth the trouble. The gesture was meant to show the hover indication if the user holds their pointer on the header, however the touch area is so small that it's most likely that the user won't be able to see the hover indication anyway, because it'll be under their finger. Furthermore, there's nothing indicating to the user that they can long press this element anyway.
crisbeto
force-pushed
the
sort-header-hammer-gesture
branch
from
add55d8 to
38b1f1a
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes remove the dependency on Hammer.js from the
matSortHeader. I decided to remove thelongpressgesture, rather than implement it with vanilla JS, because it doesn't look like it's worth the trouble. The gesture was meant to show the hover indication if the user holds their pointer on the header, however the touch area is so small that it's most likely that the user won't be able to see the hover indication anyway, because it'll be under their finger. Furthermore, there's nothing indicating to the user that they can long press this element.