Skip to content

refactor(core): allow ElementRef in RippleRenderer.setupTriggerEvents #16953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 2, 2019

The way the RippleRenderer is set up at the moment is inconsistent from an API standpoint, because the constructor only accepts an ElementRef, whereas setupTriggerEvents only accepts an HTMLElement, and in most cases they're referring to the same DOM node. These changes make the two code paths consistent with each other by allowing HTMLElement | ElementRef<HTMLElement> in both of them.

@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Sep 2, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 2, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 3, 2019
@ngbot
Copy link

ngbot bot commented Sep 3, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_browserstack" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm (personally) not really a fan of supporting both cases, as an experienced consumer of RippleRenderer should be able to retrieve the native element from the ElementRef, but yeah.. in favor of consistency this makes sense.

The way the `RippleRenderer` is set up at the moment is inconsistent from an API standpoint, because the constructor only accepts an `ElementRef`, whereas `setupTriggerEvents` only accepts an `HTMLElement`, and in most cases they're referring to the same DOM node. These changes make the two code paths consistent with each other by allowing `HTMLElement | ElementRef<HTMLElement>` in both of them.
@crisbeto crisbeto force-pushed the ripple-renderer-element-ref branch from 855b63e to 469f0b2 Compare September 8, 2019 15:29
@jelbourn jelbourn merged commit c841289 into angular:master Sep 9, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants