refactor(core): allow ElementRef in RippleRenderer.setupTriggerEvents #16953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the
RippleRenderer
is set up at the moment is inconsistent from an API standpoint, because the constructor only accepts anElementRef
, whereassetupTriggerEvents
only accepts anHTMLElement
, and in most cases they're referring to the same DOM node. These changes make the two code paths consistent with each other by allowingHTMLElement | ElementRef<HTMLElement>
in both of them.