Skip to content

docs(dialog): update dialog example #17087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2019
Merged

docs(dialog): update dialog example #17087

merged 1 commit into from
Sep 16, 2019

Conversation

peterblazejewicz
Copy link
Contributor

This is minor change in the example code replacing usage of deprecated api with new one.

Thanks!

@peterblazejewicz
docs(dialog): update dialog example
7a1c5ed 
Replace usage of deprecated api with new one
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 14, 2019
crisbeto
crisbeto approved these changes Sep 15, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 15, 2019
@jelbourn jelbourn merged commit 1dce54e into angular:master Sep 16, 2019
jelbourn pushed a commit to jelbourn/components that referenced this pull request Sep 24, 2019
@peterblazejewicz @jelbourn
docs(dialog): change afterOpen to afterOpened in example (angular…
8e1baae 
…#17087)

(cherry picked from commit 1dce54e)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2019
@peterblazejewicz peterblazejewicz deleted the replace-deprecated-dialog-call branch October 17, 2019 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterblazejewicz @crisbeto @jelbourn @googlebot