-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(material/stepper): add input for controlling the animation duration #17133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(material/stepper): add input for controlling the animation duration #17133
Conversation
I think this PR is duplicated from one I sent before (#17131). Maybe you can merge the one I mentioned and adding the examples as is the only difference I find. What do you think? |
85e5468
to
bad358e
Compare
We probably ended up working on it at the same time. Aside from the example, these changes are mostly just boilerplate. I'm not sure it makes sense to be merging it in two stages. |
I don't mind adding tests, but there isn't that much there to test. We're just passing an input along to |
The tests I added was to confirm the default values for the input is working the same as before this new input. |
bad358e
to
7d8c76f
Compare
Added a test for the logic that adds units if none are set. I don't think it makes sense to be testing default values. |
fa0011c
to
01103f7
Compare
Is there any plan to merge this soon? |
01103f7
to
7bce86f
Compare
I'm getting errors on a few tests that looks like this:
It appears the duration is misisng, but looking at the code in this PR, I don't know how that would happen. Will need to investigate further |
7bce86f
to
ba8a113
Compare
ba8a113
to
1a3b5c5
Compare
1a3b5c5
to
e2dd016
Compare
20a7f1b
to
bb46f54
Compare
Adds a new input called `animationDuration` that allows users to control the animation duration of a stepper, similarly to other components. Fixes angular#17130.
bb46f54
to
79aa133
Compare
…ion (angular#17133) Adds a new input called `animationDuration` that allows users to control the animation duration of a stepper, similarly to other components. Fixes angular#17130.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds a new input called
animationDuration
that allows users to control the animation duration of a stepper, similarly to other components.Fixes #17130.