Skip to content

feat(material/stepper): add input for controlling the animation duration #17133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

crisbeto
Copy link
Member

Adds a new input called animationDuration that allows users to control the animation duration of a stepper, similarly to other components.

Fixes #17130.

@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: major This PR is targeted for the next major release labels Sep 18, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 18, 2019
@ivandevp
Copy link

I think this PR is duplicated from one I sent before (#17131). Maybe you can merge the one I mentioned and adding the examples as is the only difference I find. What do you think?

@crisbeto crisbeto force-pushed the 17130/stepper-animation-duration branch from 85e5468 to bad358e Compare September 18, 2019 17:25
@crisbeto
Copy link
Member Author

We probably ended up working on it at the same time. Aside from the example, these changes are mostly just boilerplate. I'm not sure it makes sense to be merging it in two stages.

@mmalerba
Copy link
Contributor

I just reviewed #17131, that one doesn't have examples and this one doesn't have tests. @ivandevp or @crisbeto, does one of you want to make a PR that includes both?

@crisbeto
Copy link
Member Author

I don't mind adding tests, but there isn't that much there to test. We're just passing an input along to @angular/animations.

@ivandevp
Copy link

The tests I added was to confirm the default values for the input is working the same as before this new input.

@crisbeto crisbeto force-pushed the 17130/stepper-animation-duration branch from bad358e to 7d8c76f Compare September 18, 2019 17:48
@crisbeto
Copy link
Member Author

Added a test for the logic that adds units if none are set. I don't think it makes sense to be testing default values.

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 18, 2019
@ngbot
Copy link

ngbot bot commented Sep 18, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure conflicts with base branch "master"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto crisbeto force-pushed the 17130/stepper-animation-duration branch 2 times, most recently from fa0011c to 01103f7 Compare September 18, 2019 18:46
@ivandevp
Copy link

Is there any plan to merge this soon?

@crisbeto crisbeto force-pushed the 17130/stepper-animation-duration branch from 01103f7 to 7bce86f Compare September 29, 2019 15:14
@mmalerba mmalerba added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Oct 3, 2019
@mmalerba
Copy link
Contributor

mmalerba commented Oct 3, 2019

I'm getting errors on a few tests that looks like this:

@stepTransition has failed due to:
- Please provide a value for the animation param animationDuration
- The provided timing value " cubic-bezier(0.35, 0, 0.25, 1)" is invalid.

It appears the duration is misisng, but looking at the code in this PR, I don't know how that would happen. Will need to investigate further

@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: major This PR is targeted for the next major release labels Oct 3, 2019
@crisbeto crisbeto force-pushed the 17130/stepper-animation-duration branch from 7bce86f to ba8a113 Compare October 19, 2019 13:18
@crisbeto crisbeto force-pushed the 17130/stepper-animation-duration branch from ba8a113 to 1a3b5c5 Compare November 15, 2019 01:38
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@andrewseguin andrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 28, 2021
@crisbeto crisbeto force-pushed the 17130/stepper-animation-duration branch from 1a3b5c5 to e2dd016 Compare March 13, 2022 10:52
@crisbeto crisbeto requested review from a team and andrewseguin as code owners March 13, 2022 10:52
@crisbeto crisbeto changed the title feat(stepper): add input for controlling the animation duration feat(material/stepper): add input for controlling the animation duration Mar 13, 2022
@crisbeto crisbeto force-pushed the 17130/stepper-animation-duration branch 2 times, most recently from 20a7f1b to bb46f54 Compare March 15, 2022 12:28
Adds a new input called `animationDuration` that allows users to control the animation duration of a stepper, similarly to other components.

Fixes angular#17130.
@crisbeto crisbeto force-pushed the 17130/stepper-animation-duration branch from bb46f54 to 79aa133 Compare March 15, 2022 12:29
@crisbeto crisbeto merged commit cc61122 into angular:master Mar 15, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
…ion (angular#17133)

Adds a new input called `animationDuration` that allows users to control the animation duration of a stepper, similarly to other components.

Fixes angular#17130.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P4 A relatively minor issue that is not relevant to core functions presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MatStepper] Add support for custom animation duration timing
6 participants