fix(cdk/overlay): block scroll strategy throwing off scroll behavior feature detection #17223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
17221/scroll-behavior-feature-detection
branch
from
0ee45ab to
ca90b1b
Compare
jelbourn
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
17221/scroll-behavior-feature-detection
branch
from
ca90b1b to
5f3ecde
Compare
|
We're currently experiencing this issue in our application and I see that this PR is still open. Is there a workaround or a polyfill we alleviate the issue? |
crisbeto
changed the title
crisbeto
force-pushed
the
17221/scroll-behavior-feature-detection
branch
from
5f3ecde to
bfc9874
Compare
…feature detection To avoid a scrolling animation when we disable scrollig, we remove and re-set the `scroll-behavior` property on the body without feature checking it. The problem is that since we've set the property to *something*, our `scrollBehaviorSupported` feature check will be thrown off because it checks for `'scrollBehavior' in document.documentElement.style`. Fixes angular#17221.
crisbeto
force-pushed
the
17221/scroll-behavior-feature-detection
branch
from
bfc9874 to
49af4c1
Compare
|
It looks like this caused some test failures back when we last ran it through Google's internal presubmit system, but there's no note in our tracker of what those failures were, so we should give it a fresh presubmit. |
annieyw
pushed a commit
that referenced
this pull request
Jan 6, 2021
…feature detection (#17223) To avoid a scrolling animation when we disable scrollig, we remove and re-set the `scroll-behavior` property on the body without feature checking it. The problem is that since we've set the property to *something*, our `scrollBehaviorSupported` feature check will be thrown off because it checks for `'scrollBehavior' in document.documentElement.style`. Fixes #17221. (cherry picked from commit f940d34)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…feature detection (angular#17223) To avoid a scrolling animation when we disable scrollig, we remove and re-set the `scroll-behavior` property on the body without feature checking it. The problem is that since we've set the property to *something*, our `scrollBehaviorSupported` feature check will be thrown off because it checks for `'scrollBehavior' in document.documentElement.style`. Fixes angular#17221.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid a scrolling animation when we disable scrollig, we remove and re-set the
scroll-behaviorproperty on the body without feature checking it. The problem is that since we've set the property to something, ourscrollBehaviorSupportedfeature check will be thrown off because it checks for'scrollBehavior' in document.documentElement.style.Fixes #17221.