Skip to content

refactor(select): remove deprecated APIs for 9.0.0 #17230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2019
Merged

refactor(select): remove deprecated APIs for 9.0.0 #17230

merged 1 commit into from
Oct 17, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 29, 2019 •
edited
Loading

BREAKING CHANGES:

  • MatSelect.focused is now a readonly property.
  • _liveAnnouncer constructor parameter is now required.
  • transformPanel constant has been removed. Use matSelectAnimations.transformPanel.
  • matSelectAnimations.fadeInContent has been removed.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release labels Sep 29, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 29, 2019
@jelbourn
Copy link
Member

Can you add a breaking changes message to your commit?

@crisbeto
refactor(select): remove deprecated APIs for 9.0.0
5e8d301 
BREAKING CHANGES:
* `MatSelect.focused` is now a readonly property.
* `_liveAnnouncer` constructor parameter is now required.
* `transformPanel` constant has been removed. Use `matSelectAnimations.transformPanel`.
* `matSelectAnimations.fadeInContent` has been removed.
@crisbeto crisbeto force-pushed the select-9.0.0-breaking-changes branch from 35745df to 5e8d301 Compare September 30, 2019 16:24
@crisbeto
Copy link
Member Author

Done.

jelbourn
jelbourn approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 30, 2019
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Oct 2, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Oct 2, 2019
@mmalerba
Copy link
Contributor

mmalerba commented Oct 2, 2019

Should there be a schematic for this one?

transformPanel constant has been removed. Use matSelectAnimations.transformPanel.

@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Oct 2, 2019
@crisbeto
Copy link
Member Author

crisbeto commented Oct 2, 2019

I'm not sure whether we have the ability to write a schematic that transforms a reference to a constant to a property access expression.

@devversion
Copy link
Member

We totally can (but it will involve some work with managing imports etc.).

Most of the general cases are handled by the data/* stuff, but for special cases like that, we can either implement a new migration rule, or leave it out since it is not worth the effort.

@crisbeto
Copy link
Member Author

crisbeto commented Oct 2, 2019

That's what I meant: it's doable but we don't really have it right now. IMO this isn't really worth the effort since it's not a symbol that would be used much anyway.

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 2, 2019
@mmalerba mmalerba merged commit 818a8c7 into angular:master Oct 17, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @mmalerba @devversion @googlebot