-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/autocomplete): not closing when clicking outside while propagation is stopped #17381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(material/autocomplete): not closing when clicking outside while propagation is stopped #17381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a67c5aa
to
9721022
Compare
9721022
to
fc31804
Compare
fc31804
to
5fa2d4c
Compare
5fa2d4c
to
0d20156
Compare
…ropagation is stopped Fixes the autocomplete panel not closing if the user clicks outside on an element that stops propagation of the `click` event (e.g. a `mat-chip`). Fixes angular#17352.
0d20156
to
749d3ba
Compare
It seems like this introduced a new bug where autocompletes can escape being closed. Here's how to reproduce:
I suspect its something to do with the timing / order of the events now that we changed the click handler to the capture phase, maybe adding a |
@crisbeto does this problem still exist? |
It does, but I haven't had time to come back and try to land this change. |
@crisbeto do you know when it would be feasible to have it in release?? |
Fixes the autocomplete panel not closing if the user clicks outside on an element that stops propagation of the
click
event (e.g. amat-chip
).Fixes #17352.
Caretaker note (crisbeto): ~30 screenshot failures, handful of unit test failures testing for old behaviour