Skip to content

build: do not show inherited protected members in api docs #17430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

As per discussion in the team meeting, we do not want to show
the API documentation of inherited protected members.

The protected members should be only displayed in the API
doc of the class that declares these.

As per discussion in the team meeting, we do not want to show
the API documentation of inherited protected members.

The protected members should be only displayed in the API
doc of the class that _declares_ these.
@devversion devversion added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: merge safe target: major This PR is targeted for the next major release labels Oct 17, 2019
@devversion devversion added this to the 9.0.0 milestone Oct 17, 2019
@devversion devversion requested a review from a team as a code owner October 17, 2019 10:39
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 17, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 17, 2019
@mmalerba mmalerba merged commit e202531 into angular:master Oct 17, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants