fix(checkbox): unknown property warning with Ivy during server-side rendering

[crisbeto]

Ivy's check for whether a property supported is basically if (propName in element) which logs a warning if it doesn't match. It seems like Domino hasn't implemented the indeterminate property for input so Angular ends up logging a warning during server-side rendering. These changes switch to setting the property directly to avoid using a property binding.

Also fixes that the current Material checkbox wasn't coercing the indeterminate input to a boolean.

[devversion]

LGTM in general. Do we actually want to work around this, if it is just a warning?

I'm good working around this (just asking if doing nothing is also an option), but it might be good to submit an issue on the domino repo?

[crisbeto]

IMO we should work around it, because people using our components can't do anything about it if they're rendering on the server.

[devversion]

Yeah that is true. I guess a todo would be good with a link to an issue on the domino repo. That way, we can remove the workaround if it gets resolved.

[mmalerba]

Yeah I would say file an issue over at https://github.com/fgnass/domino and leave a TODO to clean it up if they fix it

[jelbourn]

Could we file an issue (or send a PR) for Domino and add a TODO here referencing that?

(not sure if there's more to it than adding to the input attrs object)

[jelbourn]

LGTM

[ngbot]

I see that you just added the pr: merge ready label, but the following checks are still failing:
     status "ci/circleci: lint" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

[mmalerba]

@crisbeto It looks like there's ~4 apps that have checkboxes that now appear indeterminate when they were previously unchecked. Could you split this into 2 PRs, one that fixes the SSR issue and one the fixes the coercion? That should make it easier to get the critical part in.

[crisbeto]

I don't think there's a way to split it up. We need to change the way we assign the indeterminate value in order to fix the warning.

[mmalerba]

Ok, will need to figure out what's going on with those tests before we can merge

[andrewseguin]

Needs rebase

[crisbeto]

Rebased.

[andrewseguin]

This caused two apps to break since we are now coercing the values. They both had something like [indeterminate]="selected.length && selected.length < values.length). In the case where selected is empty, the input is receiving the value 0 which is now being coerced into true.

[andrewseguin]

Creating fixes for those apps now, and will merge once that is finished

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}