Skip to content

feat(select): add injection token for configuring default options #17543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

feat(select): add injection token for configuring default options #17543

merged 1 commit into from
Jan 10, 2020

Conversation

crisbeto
Copy link
Member

Adds the MAT_SELECT_CONFIG injection token that consumers can use to customize the default options for the mat-select component.

Fixes #17406.

@crisbeto
feat(select): add injection token for configuring default options
23bb632 
Adds the `MAT_SELECT_CONFIG` injection token that consumers can use to customize the default options for the `mat-select` component.

Fixes angular#17406.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Oct 30, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 30, 2019
jelbourn
jelbourn approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 30, 2019
@jelbourn jelbourn added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Nov 19, 2019
@mmalerba mmalerba added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Dec 10, 2019
@mmalerba
Copy link
Contributor

CARETAKER NOTE: Wait until after 9.0.0 final to merge

@mmalerba mmalerba removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Jan 10, 2020
@mmalerba mmalerba merged commit dbdc1a8 into angular:master Jan 10, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@crisbeto @yifange
feat(select): add injection token for configuring default opti… (angu…
249f5e2 
…lar#17543)

Adds the `MAT_SELECT_CONFIG` injection token that consumers can use to customize the default options for the `mat-select` component.

Fixes angular#17406.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mat-select disableOptionCentering global configuration
4 participants
@crisbeto @mmalerba @jelbourn @googlebot