Skip to content

fix(ng-update): migrations not running for release candidate versions #17704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

7a433f6 set up the migrations for v9, but we actually forgot
that we want to run migrations in the next and RC versions too.

7a433f6 set up the migrations for v9, but
we actually forgot that we want to run migrations in the next and RC versions too.
@devversion devversion added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Nov 14, 2019
@devversion devversion added this to the 9.0.0 milestone Nov 14, 2019
@devversion devversion requested a review from jelbourn as a code owner November 14, 2019 11:33
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 14, 2019
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 14, 2019
@devversion devversion requested a review from a team as a code owner November 14, 2019 13:46
@devversion devversion force-pushed the fix/migrations-not-running-in-v9-next-releases branch from c45f2e8 to 518b1b4 Compare November 14, 2019 14:09
@devversion
Copy link
Member Author

devversion commented Nov 14, 2019

I pushed a second commit that validates the migration collection as part of CI, staging and releasing.

Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pending Miles' comment, I'll merge in and get the RC going

@sawyerbutton
Copy link

sawyerbutton commented Nov 26, 2019

Any hint about how material fix

Increased main.js bundle size but less lazy chunks after updating to angular 9.0.0-rc.1 #16146

problem?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants