refactor(ng-update): add links to migration guide in v9 hammer migration #17769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devversion
commented
Nov 21, 2019
•
devversion
commented
- Adds links to the migration guide in the v9 hammer migration
- Cleans up the gesture config to be less verbose, and to work with the default TSLint configuration in CLI projects
* Adds link to the migration guide in the v9 hammer migration * Cleans up the gesture config to be less verbose, and to work with the default TSLint configuration in CLI projects
googlebot
added
the
cla: yes
devversion
commented
Nov 21, 2019
| @@ -178,7 +178,8 @@ export class HammerGesturesRule extends MigrationRule<null> { | |||
| 'The HammerJS v9 migration for Angular Components detected that HammerJS is ' + | |||
| 'manually set up in combination with references to the Angular Material gesture ' + | |||
| 'config. This target cannot be migrated completely, but all references to the ' + | |||
| 'deprecated Angular Material gesture have been removed.'); | |||
| 'deprecated Angular Material gesture have been removed. Read more here: ' + | |||
| 'https://git.io/ng-material-v9-hammer-ambiguous-usage'); | |||
There was a problem hiding this comment.
I used git.io (which is an official Github service) since I don't want to show +150 chars for a perma-link. Happy to switch to something else if we can generate something like g.co/ng, or just use a real perma-link.
| @@ -228,7 +230,8 @@ export class HammerGesturesRule extends MigrationRule<null> { | |||
| this.printInfo( | |||
| 'The HammerJS v9 migration for Angular Components migrated the ' + | |||
| 'project to keep HammerJS installed, but detected ambiguous usage of HammerJS. Please ' + | |||
| 'manually check if you can remove HammerJS from your application.'); | |||
| 'manually check if you can remove HammerJS from your application. More details: ' + | |||
| 'https://git.io/ng-material-v9-hammer-ambiguous-usage'); | |||
There was a problem hiding this comment.
This overall message still feels somewhat exaggerated. It's not always ambiguous, and only rarely (see case 1 in the guide). @jelbourn do you have any idea how we can rephrase this and make it not sound like it's always wrong?
devversion
added
pr: merge safe
target: patch
jelbourn
approved these changes
Nov 21, 2019
| @@ -228,7 +230,8 @@ export class HammerGesturesRule extends MigrationRule<null> { | |||
| this.printInfo( | |||
| 'The HammerJS v9 migration for Angular Components migrated the ' + | |||
| 'project to keep HammerJS installed, but detected ambiguous usage of HammerJS. Please ' + | |||
| 'manually check if you can remove HammerJS from your application.'); | |||
| 'manually check if you can remove HammerJS from your application. More details: ' + | |||
| 'https://git.io/ng-material-v9-hammer-ambiguous-usage'); | |||
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.