Skip to content

feat(material-experimental/mdc-snackbar): Add demo. #17895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2019

Conversation

opozo
Copy link
Contributor

@opozo opozo commented Dec 7, 2019

Add demo scaffolding for MDC snackbar component

@opozo opozo requested review from jelbourn, mmalerba and a team as code owners December 7, 2019 01:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 7, 2019
@opozo opozo force-pushed the mdc-snackbar-demo branch from 69742a5 to 5af500c Compare December 7, 2019 02:09
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for Kristiyan's comment about the build deps

@jelbourn
Copy link
Member

@opozo looks like the PR needs a rebase

@opozo opozo force-pushed the mdc-snackbar-demo branch from d0e10cd to 5af500c Compare December 16, 2019 04:29
@opozo opozo force-pushed the mdc-snackbar-demo branch from 5af500c to 04e680b Compare December 16, 2019 05:48
@opozo
Copy link
Contributor Author

opozo commented Dec 16, 2019

@opozo looks like the PR needs a rebase

Done.

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 16, 2019
@mmalerba mmalerba merged commit 3ca7c5a into angular:master Dec 16, 2019
@opozo opozo deleted the mdc-snackbar-demo branch December 19, 2019 00:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants