feat(core): add test harnesses for mat-option and mat-optgroup #17940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
option-harness-2
branch
from
5c335c7 to
abd9c41
Compare
mmalerba
reviewed
Dec 11, 2019
mmalerba
added
P1
Combines the option and option group harnesses from `select/testing` and `autocomplete/testing`. Also expands the harnesses to cover all of the supported uses of the components.
crisbeto
force-pushed
the
option-harness-2
branch
from
abd9c41 to
bb97283
Compare
|
The feedback has been addressed @mmalerba. |
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines the option and option group harnesses from
select/testingandautocomplete/testing. Also expands the harnesses to cover all of the supported uses of the components.