Skip to content

refactor(cdk/drag-drop): change misleading comment #17949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2019
Merged

refactor(cdk/drag-drop): change misleading comment #17949

merged 1 commit into from
Dec 13, 2019

Conversation

michalkoziara
Copy link
Contributor

Changes misleading comment about item that was dragged into container.

@michalkoziara
refactor(cdk/drag-drop): change misleading comment
9b87ae3 
Changes misleading comment about item that was dragged into container.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 12, 2019
crisbeto
crisbeto approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like a copy-pasting mistake.

@crisbeto crisbeto added docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 12, 2019
@mmalerba mmalerba merged commit 11116d5 into angular:master Dec 13, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalkoziara @crisbeto @googlebot @mmalerba