Skip to content

docs(material/autocomplete): fix exception on page load #17956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 29, 2019
Merged

docs(material/autocomplete): fix exception on page load #17956

merged 2 commits into from
Dec 29, 2019

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Dec 13, 2019 •
edited
Loading

Fix Autocomplete Display Example throwing an exception on page load

use a proper label instead of a placeholder

Fixes #17955

@Splaktar
docs(material/autocomplete): fix exception on page load
0208ba1 
use a proper label instead of a placeholder

Fixes #17955
@Splaktar Splaktar added P2 The issue is important to a large percentage of users, with a workaround docs This issue is related to documentation target: major This PR is targeted for the next major release labels Dec 13, 2019
@Splaktar Splaktar added this to the 9.0.0 milestone Dec 13, 2019
@Splaktar Splaktar requested a review from jelbourn as a code owner December 13, 2019 03:31
@Splaktar Splaktar self-assigned this Dec 13, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 13, 2019
jelbourn
jelbourn approved these changes Dec 14, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 14, 2019
@mmalerba mmalerba merged commit 8a42b98 into master Dec 29, 2019
@mmalerba mmalerba deleted the fix-autocomplete-display-example branch December 29, 2019 22:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@Splaktar Splaktar

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

autocomplete: Display Example throws exception on material.angular.io
4 participants
@Splaktar @jelbourn @googlebot @mmalerba