build: remove unused dependencies #17988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes all unused dependencies. Also reduces dependencies needed for the legacy gulp setup that is only used for testing these days (e.g. minifying is not needed for tests; and we also don't have it in Bazel)
googlebot
added
the
cla: yes
Since we remove HTML minification from the gulp legacy output (note: we don't have HTML minification in Bazel either), paginator tests that run against IE11 and MS Edge started to fail because `innerText` returned a different value with whitepsaces in these browsers. This doesn't seem to be the case visually. We can make the tests pass consistently by removing leading/trailing whitespace.
devversion
added
pr: merge safe
target: patch
|
FYI: I looked for a ticket that described the |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all unused dependencies. Also reduces dependencies
needed for the legacy gulp setup that is only used for testing
these days (e.g. minifying is not needed for tests; and we also
don't have it in Bazel)