fix(material-experimental/mdc-slide-toggle): initial checked and disabled state not reflected visually #17991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bled state not reflected The initial `checked` and `disabled` state of the slide-toggle is not reflected visually. This is because we sync the disabled and checked state after the foundation has been created in the `ngAfterViewInit` lifecycle hook. The foundation then tries to set the classes on the MDC switch element using the adapter. The adapter just updates an object literal that will be passed through `[ngClass]` and relies on Angular to refresh the view. This won't work in Ivy because marking a component as dirty from within the `ngAfterViewInit` lifecycle hook is a noop. See: FW-1354. Just using the native element (like we do in other MDC components) solves this problem and also avoids unnecessary change detections.
devversion
added
the
target: patch
googlebot
added
the
cla: yes
crisbeto
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial
checkedanddisabledstate of the slide-toggleis not reflected visually. This is because we sync the disabled
and checked state after the foundation has been created in the
ngAfterViewInitlifecycle hook.The foundation then tries to set the classes on the MDC switch
element using the adapter. The adapter just updates an object
literal that will be passed through
[ngClass]and relies onAngular to refresh the view.
This won't work in Ivy because marking a component as dirty
from within the
ngAfterViewInitlifecycle hook is a noop at the timeof writing. See: FW-1354.
Just using the native element (like we do in other MDC components)
solves this problem and also avoids unnecessary change detections.