fix(material-experimental/mdc-chips): avoid unnecessary change detections #18043
+12
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
approved these changes
Dec 27, 2019
mmalerba
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
mdc-chips-extra-change-detections
branch
from
2539d17 to
83276b1
Compare
|
looks like theres a lint issue |
crisbeto
force-pushed
the
mdc-chips-extra-change-detections
branch
from
83276b1 to
2460ff6
Compare
crisbeto
force-pushed
the
mdc-chips-extra-change-detections
branch
from
2460ff6 to
4253d49
Compare
crisbeto
force-pushed
the
mdc-chips-extra-change-detections
branch
2 times, most recently
from
25cd59f to
ad3f743
Compare
crisbeto
force-pushed
the
mdc-chips-extra-change-detections
branch
from
ad3f743 to
7e45c83
Compare
crisbeto
force-pushed
the
mdc-chips-extra-change-detections
branch
from
7e45c83 to
a4cf2dd
Compare
…ions Avoids running the `transitionend` inside the `NgZone` for the MDC-based `mat-chip` since it fires a lot and it doesn't need to trigger change detection.
crisbeto
force-pushed
the
mdc-chips-extra-change-detections
branch
from
a4cf2dd to
dfdd323
Compare
andrewseguin
added
needs rebase
and removed
cla: yes
|
Closing since this will be resolved in #23931. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids running the
transitionendinside theNgZonefor the MDC-basedmat-chipsince it fires a lot and it doesn't need to trigger change detection.