Skip to content

docs(icon): add note about HttpClientModule requirement #18070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

crisbeto
Copy link
Member

Adds a note to the icon docs that the HttpClientModule needs to be included. Also does some minor cleanup in the overview doc.

@crisbeto crisbeto added docs This issue is related to documentation pr: merge safe P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Dec 30, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner December 30, 2019 13:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 30, 2019
@jelbourn
Copy link
Member

I couldn't help myself to changing a bit more; here's my proposed edits jelbourn@c19cea4

Adds a note to the icon docs that the `HttpClientModule` needs to be included. Also does some minor cleanup in the overview doc.
@crisbeto crisbeto force-pushed the 17870/icon-http-client-note branch from ab48d37 to 7331089 Compare January 17, 2020 13:44
@crisbeto
Copy link
Member Author

Done.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 17, 2020
@ngbot
Copy link

ngbot bot commented Jan 17, 2020

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_browserstack" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit 97a7e2b into angular:master Jan 17, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
Adds a note to the icon docs that the `HttpClientModule` needs to be included. Also does some minor cleanup in the overview doc.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants